Instantiate Binder instead of specializing it
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specialization complicates the code for no clear benefit. In fact, it had the disadvantage that use of a non-specialized `Binder` had to be flagged as an error at runtime instead of during type checking. There is backwards compatibility code to support the old syntax for a while.
While we've been using this library exclusively for configuration so far, it could be used for other purposes as well, especially if at some point we start parsing JSON.
mthuurne
force-pushed
the
instantiate-binder
branch
from
341583a to
a39cbd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the
Binderclass was specialized using a type argument (Binder[Config]) rather than instantiation (Binder(config)). The specialization complicates the code for no clear benefit. In fact, it had the disadvantage that use of a non-specializedBinderhad to be flagged as an error at runtime instead of during type checking.There is backwards compatibility code to support the old syntax for a while, but not necessarily all the way up to 1.0.