Require fields with None in their annotation to have None as their default
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do want the `for` statement to be covered, but we don't expect the loop to ever end naturally (only via `break`).
After thinking about the issue again, I realized that while it is not a particularly useful thing, it's perfectly valid to have an empty dataclass and that is a situation in which the `for` loop would exhaust its iterator.
TOML doesn't have a `None` equivalent, so we're not able to format a `None` value unless it is the default. Also we wouldn't be able to ever bind `None` to it, so user code handling `None` would be redundant.
mthuurne
changed the title
None as their defaultNone in their annotation to have None as their default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOML doesn't have a
Noneequivalent, so we're not able to format aNonevalue unless it is the default. Also we wouldn't be able to ever bindNoneto it, so user code handlingNonewould be redundant.Maybe this is something to revisit if we ever add JSON support, but for now I think this is an improvement over silently ignoring
Nonevalues.Closes #31