Add option to decrypt with signature keys #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubux
force-pushed
the
feat/flag-decrypt-signature-keys
branch
2 times, most recently
from
e309689 to
497a411
Compare
- Refactors config handling in decryption - Adds option in decryption to allow to decrypt with signature keys
lubux
force-pushed
the
feat/flag-decrypt-signature-keys
branch
from
497a411 to
1db926f
Compare
twiss
reviewed
Nov 25, 2024
crypto/decryption_handle_builder.go
Outdated
Comment on lines
178
to
179
| func (dpb *DecryptionHandleBuilder) AllowSignOnlyDecryptionKeys() *DecryptionHandleBuilder { | ||
| dpb.handle.DisableNoSignatureKeyForDecryption = true |
There was a problem hiding this comment.
We're introducing quite a lot of slightly different names for the exact same thing. Can we just call this function (and all related properties) InsecureAllowDecryptionWithSigningKeys as well?
twiss
reviewed
Nov 25, 2024
profile/profile.go
Outdated
Comment on lines
51
to
52
| // AllowSingingKeyInDecryption is a flag to enable to decrypt with signing keys for compatibility reasons. | ||
| AllowSingingKeyInDecryption bool |
There was a problem hiding this comment.
Maybe same thing here?
Suggested change
| // AllowSingingKeyInDecryption is a flag to enable to decrypt with signing keys for compatibility reasons. | |
| AllowSingingKeyInDecryption bool | |
| // InsecureAllowDecryptionWithSigningKeys is a flag to enable to decrypt with signing keys for compatibility reasons. | |
| InsecureAllowDecryptionWithSigningKeys bool |
(arguably, AllowWeakRSA should also be called InsecureAllowWeakRSA, but that's an orthogonal point..)
lubux
force-pushed
the
feat/flag-decrypt-signature-keys
branch
from
4549b4e to
10ef709
Compare
twiss
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.1.3