Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RFC for bounded recursion. #1011

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Add RFC for bounded recursion. #1011

merged 3 commits into from
Jun 9, 2021

Conversation

acoglio
Copy link
Collaborator

@acoglio acoglio commented Jun 7, 2021

This is an initial draft. As with the strings RFC, it does not have finalized before merging this. So at this stage approval of the PR just means 'okay to merge into master', without precluding the ability to edit it further (via more PRs).

Copy link
Contributor

@gluax gluax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #1011 (6dd93fc) into master (5cd05d7) will increase coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
+ Coverage   75.35%   75.81%   +0.45%     
==========================================
  Files         438      438              
  Lines       17586    17612      +26     
==========================================
+ Hits        13252    13352     +100     
+ Misses       4334     4260      -74     
Impacted Files Coverage Δ
leo/commands/setup.rs 98.14% <0.00%> (ø)
compiler/src/value/address/address.rs 66.29% <0.00%> (ø)
compiler/src/value/field/field_type.rs 90.47% <0.00%> (ø)
compiler/src/value/group/targets/edwards_bls12.rs 55.49% <0.00%> (ø)
compiler/src/statement/assign/assignee/mod.rs 90.00% <0.00%> (+0.63%) ⬆️
compiler/src/value/integer/integer.rs 81.81% <0.00%> (+1.26%) ⬆️
asg/src/const_value.rs 59.04% <0.00%> (+4.25%) ⬆️
compiler/src/value/value.rs 79.83% <0.00%> (+5.88%) ⬆️
compiler/src/expression/array/access.rs 50.41% <0.00%> (+28.09%) ⬆️
...piler/src/statement/assign/assignee/array_index.rs 89.47% <0.00%> (+59.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b59a2...6dd93fc. Read the comment docs.

Copy link
Collaborator

@bendyarm bendyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! After this is accepted, let's add the details about how the user specifies these limits and exactly how they affect the compiler.

@acoglio acoglio merged commit 8242cf4 into master Jun 9, 2021
@acoglio acoglio deleted the rfc-recursion branch June 9, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants