Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PR for Eric M.'s edits on the doc/rfc-strings branch #924

Merged
merged 2 commits into from
May 6, 2021

Conversation

acoglio
Copy link
Collaborator

@acoglio acoglio commented May 6, 2021

No description provided.

@acoglio acoglio requested a review from bendyarm May 6, 2021 03:37
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #924 (4fb3d9c) into master (7450e27) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #924      +/-   ##
==========================================
+ Coverage   77.21%   77.24%   +0.02%     
==========================================
  Files         467      467              
  Lines       20225    20225              
==========================================
+ Hits        15617    15623       +6     
+ Misses       4608     4602       -6     
Impacted Files Coverage Δ
compiler/tests/integers/int_macro.rs 92.15% <0.00%> (-2.95%) ⬇️
asg/src/reducer/visitor.rs 93.75% <0.00%> (+1.04%) ⬆️
leo/commands/build.rs 96.38% <0.00%> (+1.20%) ⬆️
compiler/tests/integers/uint_macro.rs 96.70% <0.00%> (+3.29%) ⬆️
asg/src/reducer/monoid/bool_and.rs 100.00% <0.00%> (+7.69%) ⬆️
compiler/src/phases/phase.rs 100.00% <0.00%> (+8.33%) ⬆️
ast/src/statements/expression.rs 22.22% <0.00%> (+11.11%) ⬆️
compiler/src/option.rs 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6495d...4fb3d9c. Read the comment docs.

Copy link
Collaborator

@bendyarm bendyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the change, thanks.

@acoglio acoglio merged commit 15deef6 into master May 6, 2021
@acoglio acoglio deleted the doc/rfc-strings branch May 6, 2021 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants