Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lockfile #3334

Closed
wants to merge 1 commit into from
Closed

fix: lockfile #3334

wants to merge 1 commit into from

Conversation

gluax
Copy link

@gluax gluax commented Jun 27, 2024

Motivation

The reason is that if you build or install with --locked it will lock to the version in the Cargo.lock, which currently has mixed versions of snarkVM.

This is problematic for obvious reasons.

In the future, let rust-analyzer or cargo build(without --locked) automatically fix this, no need to use cargo update.

Test Plan

All tests should hopefully still work with this if they are being run with --locked, which they should be.

Related PRs

N/A

@gluax gluax self-assigned this Jun 27, 2024
Meshiest
Meshiest approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@Meshiest Meshiest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes also cleaned up the lockfiles of our tooling that imports snarkOS

ljedrz
ljedrz approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@ljedrz ljedrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raychu86
Copy link
Contributor

raychu86 commented Jul 2, 2024 •
edited
Loading

I would close this in favor of #3342, which I believe fixes the issue by actually referencing the correct crate versions.

@raychu86 raychu86 mentioned this pull request Jul 2, 2024
Merged
@gluax
Copy link
Author

gluax commented Jul 2, 2024

@raychu86 makes sense to me. I see the same lock changes in that PR.

@gluax gluax closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meshiest Meshiest Meshiest approved these changes

@ljedrz ljedrz ljedrz approved these changes

@zosorock zosorock Awaiting requested review from zosorock

@evanmarshall evanmarshall Awaiting requested review from evanmarshall

@damons damons Awaiting requested review from damons

@vicsn vicsn Awaiting requested review from vicsn

Assignees

@gluax gluax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gluax @raychu86 @ljedrz @Meshiest