Fix SwitchRow subtitles #1392
Merged
Fix SwitchRow subtitles #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolson
changed the title
JoeMatt
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This pull request updates the QuickTableViewController dependency to v1.2.4 and contains some minor changes to fix switch row subtitles.
Where should the reviewer start
Checkout the branch and run
carthage update QuickTableViewController --platform iOS,tvOS --no-use-binaries.How should this be manually tested
Check that all four beta options have subtitles and that the "HW Lighting" core option for the "Per-pixel lighting" subtitle exists.
What are the relevant tickets
#1352
Screenshots (important for UI changes)
Before:
After QuickTableViewController v1.2.3 (bcylin/QuickTableViewController#45):
After QuickTableViewController v1.2.4 (bcylin/QuickTableViewController#50):
