expose go:wasmimport #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if !base.Flag.CompilingRuntime && base.Ctxt.Pkgpath != "syscall/js" && base.Ctxt.Pkgpath != "syscall/js_test" && base.Ctxt.Pkgpath != "syscall" { | ||
| p.error(syntax.Error{Pos: pos, Msg: "//go:wasmimport directive cannot be used outside of runtime or syscall/js"}) | ||
| break | ||
| } |
There was a problem hiding this comment.
Make this change a separate commit, since it depends on the proposal being accepted and can't be submitted just to fix golang#59156
| } | ||
|
|
||
| func makeIOVec(b []byte) unsafe.Pointer { | ||
| return unsafe.Pointer(&iovec{ | ||
| buf: uintptr32(uintptr(unsafe.Pointer(unsafe.SliceData(b)))), |
There was a problem hiding this comment.
Could this be
Suggested change
| buf: uintptr32(uintptr(unsafe.Pointer(unsafe.SliceData(b)))), | |
| buf: uintptr32(uintptr(bytesPointer(b))), |
now?
There was a problem hiding this comment.
Yes, I wanted to verify that it still remains within the inline cost threshold so it doesn't end up causing heap allocations. I may add a test to validate it.
There was a problem hiding this comment.
Yep, definitely should make a test for it 👍🏻. Also add a comment.
Adds crypto/dsa, crypto/rand, x509 files and changes for the new wasip1 port. For golang#58141 Co-authored-by: Richard Musiol <[email protected]> Co-authored-by: Achille Roussel <[email protected]> Co-authored-by: Julien Fabre <[email protected]> Co-authored-by: Evan Phoenix <[email protected]> Change-Id: I9609e3d021cd7e06b813eedf5912febc52cc0f2c
For golang#58141 Co-authored-by: Richard Musiol <[email protected]> Co-authored-by: Achille Roussel <[email protected]> Co-authored-by: Julien Fabre <[email protected]> Co-authored-by: Evan Phoenix <[email protected]> Change-Id: Ib49b7ccabe18de544455f7d09c7d715d6564a73d
For golang#58141 Co-authored-by: Richard Musiol <[email protected]> Co-authored-by: Achille Roussel <[email protected]> Co-authored-by: Julien Fabre <[email protected]> Co-authored-by: Evan Phoenix <[email protected]> Change-Id: I09a7cf33e43cb0e17ab3793c22cbad90b9e83b62
Fixes golang#58141 Co-authored-by: Richard Musiol <[email protected]> Co-authored-by: Achille Roussel <[email protected]> Co-authored-by: Julien Fabre <[email protected]> Co-authored-by: Evan Phoenix <[email protected]> Change-Id: I51dabbf17b8f5540c964f90223d18457f6f9fbef
Fixes golang#58141 Co-authored-by: Richard Musiol <[email protected]> Co-authored-by: Achille Roussel <[email protected]> Co-authored-by: Julien Fabre <[email protected]> Co-authored-by: Evan Phoenix <[email protected]> Change-Id: I49b66946acc90fdf09ed9223096bfec9a1e5b923
Now that all preceding CLs are merged, the port should be working. Change-Id: Ic45eaf42564ea286d0a429aa992c5ec0166945e9
achille-roussel
force-pushed
the
wasip1-wasm
branch
from
2516585 to
3c83fc9
Compare
Signed-off-by: Achille Roussel <[email protected]>
Signed-off-by: Achille Roussel <[email protected]>
achille-roussel
force-pushed
the
wasip1-wasm_expose-wasmimport
branch
from
5c67573 to
f4fa1ae
Compare
johanbrandhorst
force-pushed
the
wasip1-wasm
branch
from
3c83fc9 to
14e7005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.