divine pack now applies 7.77x instead of 2x #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed an issue raised by @dorijanko in discord where my previous fix would award a 2x multiplier if average corruptions were >=14 even if the player didn't have divine pack. |
|
The actual effect is correct- it should change the description instead |
Feodoric
force-pushed
the
fix-divine-pack
branch
from
0e8d685 to
f0cee9b
Compare
|
@Pseudonian force-pushed an update after rebasing onto latest master.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the octeract gain per second method was using a value of 2x for the divine pack multiplier instead of the 7.77x in the pack description. The old octeract stats display was displaying the 7.77x value.
This PR replaces the line calculating a 2x multiplier with the one from the old display method that properly calculated 7.77. Not sure if we should prefer using the
getEffect().bonusstyle of checking on upgrade status or if checking the level is ok.