Skip to content

Commit

Permalink
Remove serverRegion paramater from NoticeActiveTunnel
Browse files Browse the repository at this point in the history
The parameter will be reported by `NoticeConnectedServerRegion`
  • Loading branch information
efryntov committed Jun 6, 2024
1 parent a2cb7dc commit 50dfa02
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
3 changes: 1 addition & 2 deletions psiphon/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -1001,8 +1001,7 @@ loop:
NoticeActiveTunnel(
connectedTunnel.dialParams.ServerEntry.GetDiagnosticID(),
connectedTunnel.dialParams.TunnelProtocol,
connectedTunnel.dialParams.ServerEntry.SupportsSSHAPIRequests(),
connectedTunnel.dialParams.ServerEntry.Region)
connectedTunnel.dialParams.ServerEntry.SupportsSSHAPIRequests())

NoticeConnectedServerRegion(connectedTunnel.dialParams.ServerEntry.Region)

Expand Down
5 changes: 2 additions & 3 deletions psiphon/notice.go
Original file line number Diff line number Diff line change
Expand Up @@ -684,13 +684,12 @@ func NoticeRequestedTactics(dialParams *DialParameters) {
}

// NoticeActiveTunnel is a successful connection that is used as an active tunnel for port forwarding
func NoticeActiveTunnel(diagnosticID, protocol string, isTCS bool, serverRegion string) {
func NoticeActiveTunnel(diagnosticID, protocol string, isTCS bool) {
singletonNoticeLogger.outputNotice(
"ActiveTunnel", noticeIsDiagnostic,
"diagnosticID", diagnosticID,
"protocol", protocol,
"isTCS", isTCS,
"serverRegion", serverRegion)
"isTCS", isTCS)
}

// NoticeConnectedServerRegion reports the region of the connected server
Expand Down

0 comments on commit 50dfa02

Please sign in to comment.