Skip to content

Commit

Permalink
Merge pull request #538 from PubMatic-OpenWrap/UOE-7734-nightly
Browse files Browse the repository at this point in the history
Modified device.language to ISO-639 format 2 characters language
  • Loading branch information
kapil-tuptewar authored Jun 14, 2022
2 parents b358951 + 697d0ac commit dd731a5
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 1 deletion.
3 changes: 3 additions & 0 deletions modules/prebidServerBidAdapter/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,9 @@ function _appendSiteAppDevice(request, pageUrl, accountId) {
if (!request.device.h) {
request.device.h = window.innerHeight;
}

// update device.language to ISO-639-1-alpha-2 (2 character language)
request.device.language = request.device.language && request.device.language.split('-')[0];
}

function addBidderFirstPartyDataToRequest(request) {
Expand Down
3 changes: 3 additions & 0 deletions modules/pubmaticBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -1163,6 +1163,9 @@ export const spec = {
payload.device = Object.assign(payload.device, config.getConfig('device'));
}

// update device.language to ISO-639-1-alpha-2 (2 character language)
payload.device.language = payload.device.language && payload.device.language.split('-')[0];

// passing transactionId in source.tid
deepSetValue(payload, 'source.tid', conf.transactionId);

Expand Down
4 changes: 4 additions & 0 deletions modules/pubmaticServerBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,10 @@ export const spec = {
startTime: startTime
}
}

// update device.language to ISO-639-1-alpha-2 (2 character language)
payload.device.language = payload.device.language && payload.device.language.split('-')[0];

_handleEids(payload, validBidRequests);
return {
method: 'POST',
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/pubmaticBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1153,7 +1153,7 @@ describe('PubMatic adapter', function () {
expect(data.device.dnt).to.equal((navigator.doNotTrack == 'yes' || navigator.doNotTrack == '1' || navigator.msDoNotTrack == '1') ? 1 : 0);
expect(data.device.h).to.equal(screen.height);
expect(data.device.w).to.equal(screen.width);
expect(data.device.language).to.equal(navigator.language);
expect(data.device.language).to.equal(navigator.language.split('-')[0]);
expect(data.device.newkey).to.equal('new-device-data');// additional data from config
sandbox.restore();
});
Expand Down

0 comments on commit dd731a5

Please sign in to comment.