Skip to content

Commit

Permalink
OTT-1687: address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ashishshinde-pubm committed Apr 1, 2024
1 parent 98bb061 commit 149da61
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ require (
github.com/subosito/gotenv v1.4.2 // indirect
github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f // indirect
github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 // indirect
github.com/yudai/pp v2.0.1+incompatible // indirect
golang.org/x/crypto v0.0.0-20220525230936-793ad666bf5e // indirect
golang.org/x/sys v0.14.0 // indirect
google.golang.org/genproto v0.0.0-20230110181048-76db0878b65f // indirect
Expand Down
1 change: 0 additions & 1 deletion go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,6 @@ github.com/yudai/gojsondiff v1.0.0/go.mod h1:AY32+k2cwILAkW1fbgxQ5mUmMiZFgLIV+FB
github.com/yudai/golcs v0.0.0-20170316035057-ecda9a501e82 h1:BHyfKlQyqbsFN5p3IfnEUduWvb9is428/nNb5L3U01M=
github.com/yudai/golcs v0.0.0-20170316035057-ecda9a501e82/go.mod h1:lgjkn3NuSvDfVJdfcVVdX+jpBxNmX4rDAzaS45IcYoM=
github.com/yudai/pp v2.0.1+incompatible h1:Q4//iY4pNF6yPLZIigmvcl7k/bPgrcTPIFIcmawg5bI=
github.com/yudai/pp v2.0.1+incompatible/go.mod h1:PuxR/8QJ7cyCkFp/aUDS+JY727OFEZkTdatxwunjIkc=
github.com/yuin/goldmark v1.1.25/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
github.com/yuin/goldmark v1.1.27/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
github.com/yuin/goldmark v1.1.32/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
Expand Down
3 changes: 0 additions & 3 deletions openrtb_ext/bidders.go
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,6 @@ const (
BidderSonobi BidderName = "sonobi"
BidderSovrn BidderName = "sovrn"
BidderSspBC BidderName = "sspBC"
BidderSpotX BidderName = "spotx"
BidderStreamkey BidderName = "streamkey"
BidderStroeerCore BidderName = "stroeerCore"
BidderSuntContent BidderName = "suntContent"
Expand All @@ -506,7 +505,6 @@ const (
BidderUnicorn BidderName = "unicorn"
BidderUnruly BidderName = "unruly"
BidderValueImpression BidderName = "valueimpression"
BidderVASTBidder BidderName = "vastbidder"
BidderVideoByte BidderName = "videobyte"
BidderVideoHeroes BidderName = "videoheroes"
BidderVidoomy BidderName = "vidoomy"
Expand All @@ -526,7 +524,6 @@ const (
BidderYieldone BidderName = "yieldone"
BidderZeroClickFraud BidderName = "zeroclickfraud"
BidderZetaGlobalSsp BidderName = "zeta_global_ssp"
BidderORTBMagnite BidderName = "owortb_magnite" // OW specific: oRTB bidder for magnite
)

// CoreBidderNames returns a slice of all core bidders.
Expand Down
8 changes: 8 additions & 0 deletions openrtb_ext/bidders_ow.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package openrtb_ext

// constant of OW specific bidders
const (
BidderORTBMagnite BidderName = "owortb_magnite"
BidderSpotX BidderName = "spotx"
BidderVASTBidder BidderName = "vastbidder"
)

0 comments on commit 149da61

Please sign in to comment.