UOE-3793 Add a new request specific object to request extension #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d modified pubmatic adapter to retrieve and use info from prebid request extension
…ately reflect request specific object
PubMatic-OpenWrap
pushed a commit
that referenced
this pull request
Apr 2, 2019
* Create placeholder type for Consumable adapter. * Create placeholder type for Consumable parameters. * Create placeholder JSON Schema for Consumable parameters. * Create skeleton implementation of Bidder for ConsumableAdapter. * Add placeholder NewConsumableBidder function. * Add Consumable to adapter map. * Add comment to ExtImpConsumable. * Generate skeleton bid request. * Set User-Agent header. * Set Forwarded and X-Forwarded-For headers. * Set Referer header. * Set Origin header. * Add type representing ad placement. * Add type representing user. * Add type representing Bid Request. * Add placeholder JSON body to request. * Populate Time field of bid request. * Populate more fields of bid request. * Don't panic if request.Site is nil. * #8 Initial partial implmentation of MakeBids * #11 Add initial exemplary test to get things going * #8 Some initial correct-looking impl and test for MakeBids * Partially implement creating placements from impressions. * #4 Add ExtImpConsumable contract class * #6 Add handling of Ext.SiteId and NetworkId * #11 Provide configurable instant time source to allow testing * #6 Add conversion of w,h formats to adtypes in MakeRequests * #8 Implement retrieveAd for ad markup * #4 Update JSON Schema to match prebid.js consumable docs See https://github.com/prebid/prebid.github.io/blob/b7e1f6fbdbdb87b2b8cd283d311e8ddb2264e599/dev-docs/bidders/consumable.md * #16 Add bidder-info/consumable.yaml * #8 Clean up comments in MakeBids * #12 Add params_test.go * #8 MakeBids: Use bid.id=decision.adId and bid.crId=decision.creativeId Also take out potential nil pointer dereferences so that we don't kill the server on omitted data. * #11 Add a JSON test for absent impressionUrl * #9 Implement usersync based on prebid.js adapter code Only question here is what to do with redirect * Make unitName optional * Duplicate networkId,siteId,unitId/Name from first placement to top of request This is to match requests observed on live sites making calls to serverbid. * Add header info to simple-banner.json test scenario * Handle adId as int64 and use for bid.crid. Use internalReq.id for bid.id Note: Need to validate that bid.id can be same on multiple bids (other adapters use rand(1000) and request.id) * #9 Turn buyeruid into azk Cookie header when calling serverbid.com * #17 Extract Consumable endpoint and usersync_url to config with defaults * #9 Update usersync to work based on templates * Add callback URL to usersync for consumable * Remove additional markup from ad markup - just pass Content.Body through * Remove println's that were accidentally committed * Organise import so consumable import is in order * Delete fmt.Printf calls that shouldn't be there * Clarify why VENDOR_ID is a TODO * Move getImp and error check within test for a valid decision
PubMatic-OpenWrap
pushed a commit
that referenced
this pull request
Aug 27, 2019
* wip * wip * wip * exploration for sharethrough prebid-server * WIP: updating sharethrough adapter to latest prebid version Co-authored-by: Chris Nguyen <[email protected]> * WIP: adding butler params to the request #164291358 Co-authored-by: Josh Becker <[email protected]> * Manage bid sizes [#164291358] Co-authored-by: Josh Becker <[email protected]> * Manage GDPR [#164291358] Co-authored-by: Josh Becker <[email protected]> * Populate prebid-server version if provided [#164291358] Co-authored-by: Josh Becker <[email protected]> * Refactor gdpr data extraction from request [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Add instant play capability [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Split in multiple files [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Add s2s-win beacon todo? replace server name by server id? [#164291358] Co-authored-by: Eddy Pechuzal <[email protected]> * Removing `server` param in s2s-win beacon (will be added in imp req) [#164291358] * Clean up code + enable syncer (#4) [#165257793] * Proper error handling (#6) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement Unit Tests (#7) * Proper error handling [#165745574] * Address review (baby clean up) + catch error that was missed [#165745574] * Implement unit tests for utils [#165891351] * Add UT for utils + butler [#165891351] Co-authored-by: Michael Duran <[email protected]> * Attempt for testing Bidder interface function implementations [#165891351] Co-authored-by: Michael Duran <[email protected]> * Finalizing Unit tests [#165891351] Co-authored-by: Chris Nguyen <[email protected]> Co-authored-by: Josh Becker <[email protected]> * Fixing sharethrough.yaml capabilities [#165891351] Co-authored-by: Josh Becker <[email protected]> * Send supplyId to imp req instead of hbSource (#5) [#165477915] * Finalize PR (#8) [#164911891] Co-authored-by: Josh Becker <[email protected]> * Remove test setting * Add Sharethrough in syncer_test * Update deserializing of third party partners * Refactor/optimize UserAgent parsing (#9) following josephveach's review in prebid#903 * Addressing June 3rd review from prebid#903 Optimizations, clean up suggested by @mansinahar * Addressing June 4th review from prebid#903 (#10) * Addressing June 4th review from prebid#903 Clean up canAutoPlayVideo + hardcode bhVersion to unknown for now... * Removing hbVersion butler param since it's not accessible * Fix adMarkup error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added request specific composite object to prebid request extension to be passed on the adapters. modified pubmatic adapter to retrieve and use it