Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from Prebid Master 20201015 #6

Merged
merged 102 commits into from
Oct 15, 2020
Merged
Changes from 1 commit
Commits
Show all changes
102 commits
Select commit Hold shift + click to select a range
1704572
PubMatic BidAdapter: pass auctionId as default value for wiid param (…
pm-harshad-mane Sep 14, 2020
30a069c
Audigent HaloID User Id System Module (#5524)
antlauzon Sep 15, 2020
7da0521
Fix typo in TheMediaGrid Bid Adapter (#5589)
TheMediaGrid Sep 15, 2020
183ff52
Check localstorage availability before accessing it (#5616)
Swiiip Sep 15, 2020
f61be0c
Add Supply Supply Chain Object Module support for Yieldlab Adapter (#…
mirkorean Sep 15, 2020
cb733da
Livewrapped support for video (#5724)
bjorn-lw Sep 15, 2020
04ea603
Intentiq id value change (#5746)
yuvalgg Sep 16, 2020
298139f
add quantcast ID submodule (#5727)
mckurt Sep 16, 2020
bce32dc
upgrade ci resource (#5725)
Fawke Sep 16, 2020
140a67c
Rubicon analytics v2 (#5698)
robertrmartinez Sep 16, 2020
fd9a0d4
Add gdpr support to ablida bid adapter (#5741)
Sep 16, 2020
a3aa5f4
added onBidWon event (#5679)
adxpremium Sep 16, 2020
9452050
mapping spotx dealid to bid object (#5745)
khatibda Sep 16, 2020
bfb182a
fix broken unit tests for zeotap (#5758)
robertrmartinez Sep 16, 2020
a2c6128
Add guideline to check for GVL ID (#5757)
Fawke Sep 17, 2020
172980b
Added instream BID_WON tracking (#5481)
monis0395 Sep 17, 2020
db225e9
feat: add getEvents method to the public API (#5703)
gpolaert Sep 17, 2020
5911c6e
Prebid 4.8.0 Release
robertrmartinez Sep 17, 2020
cd4d0d8
Increment pre version
robertrmartinez Sep 17, 2020
89d829f
【MediaGoBidderAdapter】notify server if the page is secure and check m…
SylviaF Sep 18, 2020
6480715
ConnectAd Update: gvlid, better bidfloor support, transform type for …
rtuschkany Sep 19, 2020
743d6fc
No bid version 1.2.8 (#5630)
redaguermas Sep 21, 2020
f1793d3
adds support for zone and pubId params (#5728)
susyt Sep 21, 2020
e7501a9
Change the data type of gdpr and schain object in Payload (#5770)
thuyhq Sep 21, 2020
8ef4f9d
Update Openx analytics adapter (#5761)
kenan-gillet Sep 21, 2020
7c9c60d
Only set dimensions if can be resolved (#5769)
robertrmartinez Sep 21, 2020
b211409
Native support for Logicad adapter (#5742)
yuki-tsuchiya Sep 21, 2020
9297612
welect: update parameters to match backend specs of tcf2.0 (#5613)
nduitz Sep 22, 2020
52ff5e6
Initial checkin jixie adapter files (#5751)
jxdeveloper1 Sep 22, 2020
c210287
Rubicon Bid Adapter: Let host be configurable (#5779)
robertrmartinez Sep 22, 2020
4bddb0b
Rubicon Analytics Adapter: Custom Key Value reporting (#5778)
robertrmartinez Sep 22, 2020
b3e81e4
Prebid 4.9.0 Release
jsnellbaker Sep 22, 2020
540c7de
increment pre version
jsnellbaker Sep 22, 2020
1b932a0
Britepool user id module update (#5750)
bansawbanchee Sep 23, 2020
5f598b4
Add a new param cid to bridgewellBidAdapter (#5764)
rigelbibi Sep 23, 2020
8b9b86a
Refactor refererDetection to allow for URL discovery on AMP pages. (#…
mgriego Sep 23, 2020
6ea04f9
Intentiq id add url params (#5771)
yuvalgg Sep 24, 2020
7f2d81a
added instream video ad support (#5766)
drilon-kastrati Sep 24, 2020
80fc5b6
feat(sublimeBidAdapter): updating sublimeBidAdapter module (#5726)
fgcloutier Sep 24, 2020
27fe52a
Add GVL ID and bidder code to CriteoId module (#5781)
jesusalber1 Sep 24, 2020
3612308
Update BrightMountainMedia cookie sync URL (#5740)
Sep 24, 2020
f1ea594
Convert id5id to an object to support passing additional data points …
smenzer Sep 24, 2020
7aff389
Smaato: Support in-app use cases (#5765)
sbrosinski Sep 25, 2020
0fd7205
Added GVLID to Media.net Analytics Adapter (#5789)
monis0395 Sep 25, 2020
c8176d7
Add video ad support to ablida bid adapter (#5782)
Sep 25, 2020
05a5a96
Add adrelevantis adapter (#5735)
ghguo Sep 25, 2020
ecd05a3
Adnow bidder (#5738)
vingood Sep 25, 2020
b2f0c6d
Improve error and documentation for publisherId (#5788)
jsut Sep 25, 2020
280e957
SpotX bid adapter: add page parameter (#5784)
agdillon Sep 28, 2020
ebb51fb
Media.net Analytics improvements (#5755)
monis0395 Sep 28, 2020
c696e00
adagio Bid Adapter: add support for CCPA, COPPA (#5749)
osazos Sep 28, 2020
a054aa0
PubMatic analytics adapter: Not passing GDPR information (#5791)
pm-harshad-mane Sep 28, 2020
8168453
GumGum: adds support for new field - iriscat (#5790)
susyt Sep 29, 2020
eb9cf3f
fix a few id5 docs (#5793)
smenzer Sep 29, 2020
739bad8
New PubProvided Id UserId Submodule (#5767)
YerkovichM Sep 29, 2020
92e234c
standardize rubicon get config calls (#5780)
robertrmartinez Sep 29, 2020
242efdc
Prebid 4.10.0 Release
Sep 29, 2020
08e2bf2
Increment pre version
Sep 29, 2020
61e1485
Add Inmar bidder adapter (#5674)
zandree-owneriq Sep 30, 2020
083d76e
added detect referer (#5759)
ignat-one Sep 30, 2020
0c9bbf9
Qwarry bid adapter (#5662)
pro-nsk Sep 30, 2020
9573a42
Allow selection of supported default targeting keys at configuration …
mimenet Sep 30, 2020
1df6a22
cointrafficBidAdapter: added support responding in different currenci…
stsepelin Oct 1, 2020
303ccae
Send proper slot info in case of adUnitPath (#5810)
monis0395 Oct 1, 2020
c1c6aaa
Update to rubiconBidAdapter to include criteoId support (#5806)
mmoschovas Oct 1, 2020
804ff2f
appnexus bid adapter: criteo back to tpuids (#5808)
jsnellbaker Oct 1, 2020
907a9c7
Intentiq id add validation (#5797)
yuvalgg Oct 1, 2020
b5cf481
remove digitrust from rubicon bid adapter (#5798)
robertrmartinez Oct 5, 2020
ca22a45
add native preset handling and automatic price macro replacement (#5807)
mlequain Oct 5, 2020
664ec3b
fix some video request params (#5799)
robertrmartinez Oct 5, 2020
aa1e5e3
expose full user id config (including storage) to user id modules (#5…
smenzer Oct 6, 2020
ea498f9
Fix timeToFirstByte unit test (#5820)
Viewtiful Oct 6, 2020
8982e09
rubicon: adding pubcid support (#5824)
bretg Oct 6, 2020
16fabf4
Appnexus: Add omid support (#5821)
Fawke Oct 7, 2020
f907ee6
new userId module - neustar's fabrick (#5802)
andersonbd1 Oct 7, 2020
c57bab7
Integrate option to pass clickThrough urls to renderAd method (#5796)
renebaudisch Oct 7, 2020
ba1a35c
Add credentials and explicit options to CriteoIdSystem (#5822)
Swiiip Oct 7, 2020
e082c83
AdYouLike bidAdapter - Add information in bid request (#5828)
guiann Oct 7, 2020
84e7121
4.11.0 release
mkendall07 Oct 7, 2020
752bd27
4.12.0-pre
mkendall07 Oct 7, 2020
7d27095
IDx user id submodule (#5826)
rtoscani Oct 8, 2020
ab4f80a
Adding Test mode for the IronSource bidder (#5831)
liranbaruch Oct 8, 2020
32495f9
Adtelligent: Add new alias (#5825)
GeneGenie Oct 9, 2020
8449994
Add vuukle adapter (#5773)
Hamper Oct 9, 2020
b6bfbef
Handling video outstream in smartadserver adapter. (#5739)
tadam75 Oct 9, 2020
e39a812
add stroeerCoreBidAdapter (#5830)
Kubitini Oct 12, 2020
ad41a19
Added the ability to send multiple bids in one ad request for mediafo…
Niksok Oct 12, 2020
77293a4
Force refresh userId (#5819)
TLadd Oct 13, 2020
511e16a
Hybrid adapter. Added support In-Image format (#5754)
hybrid-ai Oct 13, 2020
a2c63e1
PubMatic Analytics: internal kgpv param support in analytics (#5849)
pm-harshad-mane Oct 13, 2020
666c82f
TrueReach Bidder Adapter: Added User Sync Support (#5846)
mmprebid Oct 13, 2020
1b76f45
Don't parse the querystring when extracting the protocolHost (#5851)
kero75 Oct 13, 2020
3bc0bf9
Add rubicon size 548 (#5853)
ACannuniRP Oct 13, 2020
c251ad5
PR Review Process: Adding RTD, UserId. General modernization. (#5829)
bretg Oct 13, 2020
916972b
ATS-analytics - add retry logic to not fire request for envelope ever…
mamatic Oct 14, 2020
c4d0f99
Add examples and tests for criteo User Id Module (#5838)
Swiiip Oct 14, 2020
681b4ea
Fix size validate (#5841)
r-ishigami Oct 14, 2020
e9d1fb5
fix adunit.bid undefined edge case (#5827)
Fawke Oct 14, 2020
4df3696
PubMatic Analytics: pass device platform related information (#5855)
pm-harshad-mane Oct 14, 2020
2c1cd89
Prebid 4.12.0 Release
robertrmartinez Oct 14, 2020
13a0425
git commit -m "Increment pre version"
robertrmartinez Oct 14, 2020
f545a56
add ooloAnalyticsAdapter (#5852)
roygiladi Oct 15, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handling video outstream in smartadserver adapter. (prebid#5739)
* Handling video outstream in smartadserver adapter.

* Fixing the outstream example with the queue handler.

Co-authored-by: tadam <[email protected]>
  • Loading branch information
tadam75 and tadam authored Oct 9, 2020
commit b6bfbef1db6c4533a0a40cf61490d47022df2b37
8 changes: 5 additions & 3 deletions modules/smartadserverBidAdapter.js
Original file line number Diff line number Diff line change
@@ -83,10 +83,11 @@ export const spec = {
w: size[0],
h: size[1]
}));
} else if (videoMediaType && videoMediaType.context === 'instream') {
} else if (videoMediaType && (videoMediaType.context === 'instream' || videoMediaType.context === 'outstream')) {
// Specific attributes for instream.
let playerSize = videoMediaType.playerSize[0];
payload.isVideo = true;
payload.isVideo = videoMediaType.context === 'instream';
payload.mediaType = VIDEO;
payload.videoData = {
videoProtocol: bid.params.video.protocol,
playerWidth: playerSize[0],
@@ -146,10 +147,11 @@ export const spec = {
ttl: response.ttl
};

if (bidRequest.isVideo) {
if (bidRequest.mediaType === VIDEO) {
bidResponse.mediaType = VIDEO;
bidResponse.vastUrl = response.adUrl;
bidResponse.vastXml = response.ad;
bidResponse.content = response.ad;
} else {
bidResponse.adUrl = response.adUrl;
bidResponse.ad = response.ad;
39 changes: 39 additions & 0 deletions modules/smartadserverBidAdapter.md
Original file line number Diff line number Diff line change
@@ -94,4 +94,43 @@ Please reach out to your Technical account manager for more information.
}
}]
};
```

## Outstream Video

```
var outstreamVideoAdUnit = {
code: 'test-div',
mediaTypes: {
video: {
context: 'outstream',
playerSize: [640, 480]
}
},
renderer: {
url: 'https://acdn.adnxs.com/video/outstream/ANOutstreamVideo.js',
render: function (bid) {
bid.renderer.push(() => {
ANOutstreamVideo.renderAd({
targetId: bid.adUnitCode,
adResponse: bid
});
});
}
},
bids: [{
bidder: "smart",
params: {
domain: 'https://prg.smartadserver.com',
siteId: 207435,
pageId: 896536,
formatId: 85089,
bidfloor: 5,
video: {
protocol: 6,
startDelay: 1
}
}
}]
};
```
104 changes: 104 additions & 0 deletions test/spec/modules/smartadserverBidAdapter_spec.js
Original file line number Diff line number Diff line change
@@ -425,6 +425,7 @@ describe('Smart bid adapter tests', function () {
expect(bid.mediaType).to.equal('video');
expect(bid.vastUrl).to.equal('http://awesome.fake-vast.url');
expect(bid.vastXml).to.equal('<VAST version="4.0"></VAST>');
expect(bid.content).to.equal('<VAST version="4.0"></VAST>');
expect(bid.width).to.equal(640);
expect(bid.height).to.equal(480);
expect(bid.creativeId).to.equal('zioeufg');
@@ -473,6 +474,109 @@ describe('Smart bid adapter tests', function () {
});
});

describe('Outstream video tests', function () {
afterEach(function () {
config.resetConfig();
$$PREBID_GLOBAL$$.requestBids.removeAll();
});

const OUTSTREAM_DEFAULT_PARAMS = [{
adUnitCode: 'sas_43',
bidId: 'abcd1234',
bidder: 'smartadserver',
mediaTypes: {
video: {
context: 'outstream',
playerSize: [[800, 600]] // It seems prebid.js transforms the player size array into an array of array...
}
},
params: {
siteId: '1234',
pageId: '5678',
formatId: '91',
target: 'test=prebid-outstream',
bidfloor: 0.430,
buId: '7579',
appName: 'Mozilla',
ckId: 43,
video: {
protocol: 7
}
},
requestId: 'efgh5679',
transactionId: 'zsfgzzga'
}];

var OUTSTREAM_BID_RESPONSE = {
body: {
cpm: 14,
width: 800,
height: 600,
creativeId: 'zioeufga',
currency: 'USD',
isNetCpm: true,
ttl: 300,
adUrl: 'http://awesome.fake-vast2.url',
ad: '<VAST version="4.0"><!--Outstream--></VAST>',
cSyncUrl: 'http://awesome.fake2.csync.url'
}
};

it('Verify outstream video build request', function () {
config.setConfig({
'currency': {
'adServerCurrency': 'EUR'
}
});
const request = spec.buildRequests(OUTSTREAM_DEFAULT_PARAMS);
expect(request[0]).to.have.property('url').and.to.equal('https://prg.smartadserver.com/prebid/v1');
expect(request[0]).to.have.property('method').and.to.equal('POST');
const requestContent = JSON.parse(request[0].data);
expect(requestContent).to.have.property('siteid').and.to.equal('1234');
expect(requestContent).to.have.property('pageid').and.to.equal('5678');
expect(requestContent).to.have.property('formatid').and.to.equal('91');
expect(requestContent).to.have.property('currencyCode').and.to.equal('EUR');
expect(requestContent).to.have.property('bidfloor').and.to.equal(0.43);
expect(requestContent).to.have.property('targeting').and.to.equal('test=prebid-outstream');
expect(requestContent).to.have.property('tagId').and.to.equal('sas_43');
expect(requestContent).to.not.have.property('pageDomain');
expect(requestContent).to.have.property('transactionId').and.to.not.equal(null).and.to.not.be.undefined;
expect(requestContent).to.have.property('buid').and.to.equal('7579');
expect(requestContent).to.have.property('appname').and.to.equal('Mozilla');
expect(requestContent).to.have.property('ckid').and.to.equal(43);
expect(requestContent).to.have.property('isVideo').and.to.equal(false);
expect(requestContent).to.have.property('videoData');
expect(requestContent.videoData).to.have.property('videoProtocol').and.to.equal(7);
expect(requestContent.videoData).to.have.property('playerWidth').and.to.equal(800);
expect(requestContent.videoData).to.have.property('playerHeight').and.to.equal(600);
});

it('Verify outstream parse response', function () {
const request = spec.buildRequests(OUTSTREAM_DEFAULT_PARAMS);
const bids = spec.interpretResponse(OUTSTREAM_BID_RESPONSE, request[0]);
expect(bids).to.have.lengthOf(1);
const bid = bids[0];
expect(bid.cpm).to.equal(14);
expect(bid.mediaType).to.equal('video');
expect(bid.vastUrl).to.equal('http://awesome.fake-vast2.url');
expect(bid.vastXml).to.equal('<VAST version="4.0"><!--Outstream--></VAST>');
expect(bid.content).to.equal('<VAST version="4.0"><!--Outstream--></VAST>');
expect(bid.width).to.equal(800);
expect(bid.height).to.equal(600);
expect(bid.creativeId).to.equal('zioeufga');
expect(bid.currency).to.equal('USD');
expect(bid.netRevenue).to.equal(true);
expect(bid.ttl).to.equal(300);
expect(bid.requestId).to.equal(OUTSTREAM_DEFAULT_PARAMS[0].bidId);

expect(function () {
spec.interpretResponse(OUTSTREAM_BID_RESPONSE, {
data: 'invalid Json'
})
}).to.not.throw();
});
});

describe('External ids tests', function () {
it('Verify external ids in request and ids found', function () {
config.setConfig({