Fix doubled braces in attributes

[sungam3r]

fixes #410

---

This PR was superseded by #414.

[sungam3r]

Wow! Not reproducable locally, but reproducable in CI.

[sungam3r]

There are no doubled (( on NET FRAMEWORK.

[siewers]

Okay, then it makes more sense.
I'm not using .NET Framework so I did not test that 🙂

[sungam3r]

@stakx @jnyrup please take a look. I'll keep it 1-2 days before merging. I would like to release this one with #342.

[jnyrup]

This doesn't work with the example from #410 because it has an extra parameter after the long string.

        [Fact]
        public void Should_handle_attribute_with_long_string_initialiser2()
        {
            AssertPublicApi<ClassWithAttributeWithLongStringInitialiser2>(
                @"namespace PublicApiGeneratorTests.Examples
{
    [System.Obsolete(""This is a veeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee"" +
        ""eeeeeeery long string that will be surrounded by parenthesis due to how it\'s han"" +
        ""dled by Microsoft.CodeDom"", false)]
    public class ClassWithAttributeWithLongStringInitialiser2
    {
        public ClassWithAttributeWithLongStringInitialiser2() { }
    }
}");
        }

[Obsolete("This is a veeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeery long string that will be surrounded by parenthesis due to how it's handled by Microsoft.CodeDom", false)]
public class ClassWithAttributeWithLongStringInitialiser2()
{
}

There's also other cases to consider:

• Ending with long string parameter [SomeAttribute(false, "loooong string")]
• Multiple long strings parameters [SomeAttribute("loooong string", "loooong string")]

Looking at the commit history for System.CodeDom dotnet/runtime#96948 is the only change between 8.0.0 and 9.0.0.
Skimming the fixed issue, I'm not sure if the fix is relevant for PublicApiGenerator.

So how about:

• Downgrade System.CodeDom to 8.0.0
• Undo the changes to CodeNormalizer
• Keep Should_handle_attribute_with_long_string_initialiser as a regression test

[sungam3r]

You are right. It turned out to be not so easy to fix this error only by replacing lines. As a result, I copied all needed code to generate results and commented out problem line.

[sungam3r]

All tests are green now.

Downgrade System.CodeDom to 8.0.0

I understand but downgrading may lead to additional noise with dependabot.

[jnyrup]

dependabot should keep silent if we fix the version using Version=[8.0.0].

In Fluent Assertions, we have configured dependabot to ignore certain dependecies
https://github.com/fluentassertions/fluentassertions/blob/ec0192465b6009ff356c31eeee9adf4187b2496e/.github/dependabot.yml#L27-L37

[sungam3r]

I know that feature. Nevertheless I'm 50/50 now to go on with these changes or revert to 8.

[sungam3r]

@jnyrup I decided to revert System.CodeDom to 8 in #414, publish release and keep #412 opened just in case.

[sungam3r]

@jnyrup I achieved a minimum possible diff to fix this issue.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 29.90%. Comparing base (cc2b2e5) to head (e64e7b5).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...ApiGenerator/System.CodeDom/CSharpCodeGenerator.cs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #412       +/-   ##
===========================================
- Coverage   86.24%   29.90%   -56.35%     
===========================================
  Files          21       26        +5     
  Lines        1345     3879     +2534     
  Branches      239      634      +395     
===========================================
  Hits         1160     1160               
- Misses        147     2674     +2527     
- Partials       38       45        +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.