Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] R2S scripting improvements #136

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

Redmoonwow
Copy link
Contributor

A problem occurred due to a null reference, so it was fixed and improved.

  • OnMessage() is called frequently, so it was changed to OnStartingCast() to reduce processing.
  • OnUpdate() is called every tick, so the processing was moved to OnActionEffectEvent() to reduce processing.
  • Changed to refer to set instead of Player.Object, and strictly checks whether set and set.action are null, so null reference errors do not occur.
  • OnVfx() can also be integrated with OnActionEffectEvent(), so it was changed to process with OnActionEffectEvent().
  • Corrected the typo that said "target" as the argument to OnStartingCast should be "source."
  • Changed the argument to OnStartingCast to pass DataID instead of EntityID as the argument to sourceID.

@Limiana Limiana merged commit e448e27 into PunishXIV:main Aug 22, 2024
@Limiana
Copy link
Collaborator

Limiana commented Aug 22, 2024

Thank you!

@Redmoonwow Redmoonwow deleted the fix/R2S-script-fix branch August 24, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants