-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #44 #52
Merged
Merged
Issue #44 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeperfectplus
added a commit
that referenced
this pull request
Nov 17, 2022
* better cli output * updating documentation * updating documentation * updating badge * updating changelog * Update publish.yml * updating setup.py * Update README.md * first stable release Signed-off-by: Deepak Raj <[email protected]> * Update CHANGELOG.md * updating cli * refactoring code Signed-off-by: Deepak Raj <[email protected]> * fixing flake8 error * bug fixed Signed-off-by: Deepak Raj <[email protected]> * tested * flake8 error * flake8 error * refactroing code * updating docs Signed-off-by: Deepak Raj <[email protected]> * test cases updated * test cases updated * adding scripts for release automation (#49) * bumping version 1.0.0 to 2.0.0 (#50) * adding scripts for release automation * v2.0.0 releasing * updating changelog Signed-off-by: Deepak Raj <[email protected]> * Delete update_package.sh * Update FUNDING.yml * Update FUNDING.yml * Issue #44 (#52) * add gender options for first names * add gender options for first names, random card * add job experience according to years of age * add parameter option for logging (not implemented yet) * add handpicked locations to cities in list * add float coords generation * add coordinates string formatting * fix ages in job level generation * start of unit tests * add more tests * add assertregex ussage in tests * fix missing imports * lint fixes * two lines padding before class * solving git conflict * refactoring code Signed-off-by: Deepak Raj <[email protected]> * refacoting code and changelog update * Update FUNDING.yml Signed-off-by: Deepak Raj <[email protected]> Co-authored-by: Rahul Sharma <[email protected]> Co-authored-by: DavidCano98 <[email protected]>
codeperfectplus
added a commit
that referenced
this pull request
Nov 17, 2022
* better cli output * updating documentation * updating documentation * updating badge * updating changelog * Update publish.yml * updating setup.py * Update README.md * first stable release Signed-off-by: Deepak Raj <[email protected]> * Update CHANGELOG.md * updating cli * refactoring code Signed-off-by: Deepak Raj <[email protected]> * fixing flake8 error * bug fixed Signed-off-by: Deepak Raj <[email protected]> * tested * flake8 error * flake8 error * refactroing code * updating docs Signed-off-by: Deepak Raj <[email protected]> * test cases updated * test cases updated * adding scripts for release automation (#49) * bumping version 1.0.0 to 2.0.0 (#50) * adding scripts for release automation * v2.0.0 releasing * updating changelog Signed-off-by: Deepak Raj <[email protected]> * Delete update_package.sh * Update FUNDING.yml * Update FUNDING.yml * Issue #44 (#52) * add gender options for first names * add gender options for first names, random card * add job experience according to years of age * add parameter option for logging (not implemented yet) * add handpicked locations to cities in list * add float coords generation * add coordinates string formatting * fix ages in job level generation * start of unit tests * add more tests * add assertregex ussage in tests * fix missing imports * lint fixes * two lines padding before class * solving git conflict * refactoring code Signed-off-by: Deepak Raj <[email protected]> * refacoting code and changelog update * Update FUNDING.yml * fixing bug the project link and formated code base with flake8 (#53) Signed-off-by: Deepak Raj <[email protected]> Co-authored-by: Rahul Sharma <[email protected]> Co-authored-by: DavidCano98 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you Changed
1. Data should be generated based on Gender. fname file will be rewritten. There will be 2 files.
fnames_male.txt
andfnames_female.txt
(male names from original file, new random female names)2. Generate Geo Coordinate, should be from the same city.
cities_name.txt
data to for exampleMetropolis;22.574280;113.932504
generate_random_city_coords(cities)
to generate random city from list with random coordinatesrandom_coords_from_point(lat: float, lon: float, max_distance: float = 1000)
generates a random coordinate point away max.max_distance
meters, away from point (lat, lon)3. Generate Father/Mother's name as well in the profile section.
mother
andfather
4. Generate fake Credit/Debit Card
generate_random_card()
that outputs a dictionary with structur:`{
}`
5. with the job title there should be job experience it should match with age
added
job_levels.txt
with data:`entry-level;0;22
intermediate;23;26
mid-level;27;37
senior;38;50
executive;51;100`
first part is level name, other two are minimal and maximal age for level
generate_random_job_level(age: int, levels)
to get matching job level for given ageIssue no.(must) - 44
Proposed feature in upcoming version
Self Check(Tick After Making pull Request)