feat: Formulario y vista para proponer una nueva charla #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP: Unit tests |
Scot3004
reviewed
Oct 22, 2023
|
Listo. Agregue iternacionalizacion también |
Scot3004
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Se ve bien el formulario
Se solicitan los siguientes cambios:
- Crear migraciones, para los help text, si se ejecuta el comando make migrations, hay cambios sin aplicar, si bien dado que son campos de ayuda no generan mayor impacto
- Traducir los mensajes faltantes, que sirven como información de ayuda para diligenciar los campos
| @@ -23,10 +23,25 @@ class InPerson(models.IntegerChoices): | |||
| description = models.CharField(_("Description"), max_length=300) | |||
| level = models.PositiveIntegerField(_("Level"), choices=Level.choices, default=Level.BEGINNER) | |||
| language = models.CharField(_("Language"), max_length=2, choices=Language.choices, default=Language.ES) | |||
| timezone = models.CharField(_("Timezone"), max_length=60) | |||
| timezone = models.CharField( | |||
There was a problem hiding this comment.
Al cambiar los modelos se requieren crear migraciones, por favor, crealas
| #: temii/talks/models.py:27 | ||
| #: temii/talks/models.py:30 | ||
| msgid "" | ||
| "Timezone of the place you are located. E.g., Colombia (UTC-5), Argentina or " |
There was a problem hiding this comment.
Creo que seria bueno traducir este mensaje
|
Listo. Agregue las migraciones y las nuevas traducciones :) |
Scot3004
requested changes
Nov 1, 2023
locale/es/LC_MESSAGES/django.po
Outdated
| @@ -100,7 +100,8 @@ msgstr "Zona horaria" | |||
| msgid "" | |||
| "Timezone of the place you are located. E.g., Colombia (UTC-5), Argentina or " | |||
| "Chile (UTC-3), Mexico (UTC-6), etc." | |||
| msgstr "" | |||
| msgstr "ona horaria del lugar donde se encuentra. Por ejemplo," | |||
There was a problem hiding this comment.
msgstr "Zona horaria del lugar donde se encuentra. Por ejemplo,"
Falta una Z
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Relacionado con #149
Observaciones
Luego de que el usuario propone una nueva charla, redirijo a una página de agradecimiento. En la lógica del formulario de google, solo el o los admins pueden ver el listado de charlas propuestas