-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #453 jinja2 template select_autoescape when using jinja2.select_autoescape #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
force-pushed
the
fix-jinja2-template
branch
3 times, most recently
from
March 25, 2019 07:04
7a73f85
to
addccf9
Compare
kinow
force-pushed
the
fix-jinja2-template
branch
from
March 25, 2019 07:07
addccf9
to
3572b7d
Compare
Aarrgh. Had a hard time fixing |
ericwb
reviewed
Jul 10, 2022
ericwb
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for reviewing and sorting out formatting and last touches to get it merged, @ericwb 👍 |
This was referenced Jul 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added a test to reproduce what was reported in #453 . Running the test first, without the patch, gives:
Hopefully Travis CI will report that this patch produced no failures in the tests. I avoided trying to check if the
jinja2
module was aliased, as I think we would have to look at the Context imports, store in a variable what was the method, and add yet anotherif
for that? But if there's a simpler way or if necessary, happy to update this pull request.Cheers
Bruno