-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request for feedback via 👍 #871
Conversation
This change encourages users to give a 👍 if they really like a particular feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly there's no way to sort by reactions. I'm not sure this will be easy to do or fulfill the promise
Believe or not, there is a way to filter by reactions: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-number-of-reactions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea±
That's sorting by total quantity, not number of 👍. So any reaction counts towards that including 👎 |
Good point. Would you prefer I revert the PR? |
I just want to be clear that this will be a manual process of sorting and then checking the reactions manually which may make this more onerous for us and thus break expectations for users who are trying to vote as we indicate. I think we should try it out, but I don't have high expectations for success personally. GitHub isn't designed for us as Open Source projects - it's designed and built almost exclusively for corporate users at this point. This is why moderation tools are crap. It's why pull request reviews are prime vectors for spam. It's why trying to manage feature requests doesn't work. I almost wonder if discussions are a better venue for feature requests than issues, even though they're completely a separate flow and notifications seem unreliable there. |
This change encourages users to give a 👍 if they really like a particular feature.