-
-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding logging.config.listen() plugin with examples #874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional plugin. I've noted some things to correct.
Also, you'll need to add a doc under doc/source/plugins/b612_......
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. I've pushed the changes. Cheers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi,
I would like to contribute a plugin based on Python's security consideration regarding
logging
.The actual issue (usage of
eval()
) is whenlogging.config.fileConfig
is called on an untrusted configuration file. However, it seems very obvious that configuration files are critical for security so will be write-protected to authorised users. The interesting attack vector is possible when an application exposes socket server to listen for configuration file from a network socket that a local attacker can exploit.So this plugin checks for usage of
logging.config.listen
withoutverify
argument which allows integrity checking or encryption/decryption capability to prevent abuse.(all tox tests passed)