Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Default Section documentation #1267

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Fix Default Section documentation #1267

merged 2 commits into from
Jul 7, 2020

Conversation

decaz
Copy link
Contributor

@decaz decaz commented Jul 5, 2020

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1267 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop     #1267   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         2133      2133           
=========================================
  Hits          2133      2133           

@timothycrosley
Copy link
Member

@decaz, the project default is now THIRDPARTY as shown lower down in that same documentation: https://github.com/timothycrosley/isort/pull/1267/files#diff-02bcb3cc356bf8c45153cbef1ab618edR298. Curious what led you to believe it was FIRSTPARTY? Is there other documentation that is incorrect, or an experience you are having integrating the project that leads to that conclusion?

Thanks!

~Timothy

@decaz
Copy link
Contributor Author

decaz commented Jul 6, 2020

@timothycrosley initially "by default FIRSTPARTY" phrase led me to believe it is FIRSTPARTY. But then I saw "Default: THIRDPARTY" and decided to make suggestion about removing "by default FIRSTPARTY" phrase from documentation.

@timothycrosley timothycrosley reopened this Jul 7, 2020
@timothycrosley
Copy link
Member

@decaz Thanks for raising this! Sorry, in the flood of comments post release, I misread the PR.

@timothycrosley timothycrosley merged commit 0c6d8a7 into PyCQA:develop Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants