This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add ignore-self-only-init option
#560
Merged
+86
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Of course, the option name is up for debate :) |
sambhav
reviewed
Dec 30, 2021
There was a problem hiding this comment.
Hey @thejcannon - thanks for the PR! Sorry for the delay in getting to review this. It generally looks good to me. Just a minor comment re:naming.
|
@thejcannon could you please rebase this PR against the master branch? Thanks! |
|
Better late than never 😅 |
|
@samj1912 got time for a quick review? |
sambhav
approved these changes
Jan 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an option
ignore-self-only-init(off by default) which will not report a D107 error if__init__has no parameters other thanself. The justification is that these methods usually aren't very interesting and will likely result in redundant/boring docstrings which add noise.Just turning off D107 isn't an option, since there are
__init__methods which are interesting ;)Please make sure to check for the following items: