-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to customize ssl mode settings #475
Conversation
… handling for MariaDB lib)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage 86.48% 86.48%
=======================================
Files 7 7
Lines 555 555
=======================================
Hits 480 480
Misses 75 75 ☔ View full report in Codecov by Sentry. |
…ion and case sensitivity)
This pull request introduces 1 alert when merging d497312 into 24aaa72 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very much interested in having something like the changes here committed to allow for using MariaDB with strict server certificate validation (the equivalent of VERIFY_IDENTITY
) but I think the changes here as is have some issues.
If there's anything I can do to help here, or to open up a separate PR, I'd love to help out.
This pull request introduces 1 alert when merging 6cdf275 into 6979a47 - view on LGTM.com new alerts:
|
According to https://mariadb.com/kb/en/mysql_optionsv/ MariaDB supports TLS enforcing in its own way. So the idea behind this PR is to keep the same interface for MariaDB based clients, but behind the scenes handle it accordingly.(MariaDB gets its own args set, instead of ssl_mode dict supported by MySQL).