-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Version #1
Conversation
when running tests in parallel on a weak machine the concurrent test worker subprocesses will be waiting on the first compilation to finish. the other tests should not have any contested locks so the extra timeout is only important for the concurrent tests.
so that clients do not need SSH credentials to be able to clone the repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know maturin uses https://pre-commit.ci/ and you can switch to that if you prefer, but this works fine too IMO. takes ~1min to run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if maturin uses an automated tool for managing the changelog. I haven't set anything up in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog isn't automated in maturin ATM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my idea is to use maturin from pypi during testing, but get the test crates from a submodule pinned at an appropriate version. The package_resolver
rust project is also required for testing and needs access to the maturin source code so this submodule serves both purposes
I've sent you an invitation to colab on this repo.
Done.
We can do that later.
Part of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, let's merge it and iterate on it.
This builds off of the original PR in the maturin repo: PyO3/maturin#1748
I have finished enough of the import hook that I think it’s ready for review. There are still improvements to be made (some ideas below) but it’s mostly just finishing touches. I am likely to be unavailable for at least the next week but I suspect reviewing will take a while anyway.
Some general points/questions about the project and repo:
here is a CI run where all the tests passed: run
At the moment I think the basics are solid enough to release but things aren't perfect. Some things still on my todo list:
importlib.reload
support on WindowsPackageBuilder
or similar, for users to customize howmaturin
is called instead of hard-codingMaturinSettings
object used for building all packagesimportlib.reload
and subprocesses/threads