Rewrite platform specific dependencies in Cargo.toml #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
messense
reviewed
Apr 20, 2023
viccie30
force-pushed
the
rewrite-platform-specific-dependencies
branch
from
73d7235 to
110625e
Compare
bors bot
added a commit
that referenced
this pull request
Apr 21, 2023
1572: Rewrite platform specific dependencies in Cargo.toml r=messense a=viccie30 This PR adds support for rewriting [platform specific dependencies](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies). I have added a test by copying `lib_with_path_dep_sdist` and changing `Cargo.toml`. Co-authored-by: Victor Westerhuis <[email protected]>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for rewriting platform specific dependencies.
I have added a test by copying
lib_with_path_dep_sdistand changingCargo.toml.