UniFFI: supports bindings generated from multiple crates #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
MatMaul
force-pushed
the
multiple-crates
branch
from
8f36bd9 to
ba93a40
Compare
MatMaul
changed the title
|
Thanks for the PR, could you please add a test crate in |
messense
reviewed
Sep 3, 2024
Co-authored-by: messense <[email protected]>
Co-authored-by: messense <[email protected]>
for more information, see https://pre-commit.ci
|
Good idea, minimal test case added. |
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes allow to build a functional wheel of Matrix Rust SDK FFI bindings.