Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make maturin develop fail if version info is missing in pyproject.toml #2418

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

mhils
Copy link
Contributor

@mhils mhils commented Dec 30, 2024

This PR implements the changes discussed in #2416 (comment) on top of #2417. Got this done faster than expected this morning, but won't have any time to incorporate feedback for the next ~ two days. Feel free to pull this in and butcher it any way you like. :)

Thanks again for your fantastic work on maturin! 🍰

@messense messense merged commit cd7828f into PyO3:main Dec 30, 2024
33 of 37 checks passed
@messense
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants