Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG: add link for unreleased changes #2616

Merged
merged 1 commit into from
Sep 13, 2022
Merged

CHANGELOG: add link for unreleased changes #2616

merged 1 commit into from
Sep 13, 2022

Conversation

davidhewitt
Copy link
Member

After moving unreleased changes to newsfragments (for towncrier) I thought it'd be helpful to add a link to the CHANGELOG to see the unreleased changes.

adamreichold
adamreichold approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. We still need to fix the coverage xtask though? Probably by just dropping --workspace?

@davidhewitt
Copy link
Member Author

We still need to fix the coverage xtask though?

Yeah agreed, I see you took a stab in #2617, I'll see if I can get anything to work too.

@davidhewitt davidhewitt merged commit 045df99 into PyO3:main Sep 13, 2022
@davidhewitt davidhewitt deleted the changelog-unreleased branch September 13, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @adamreichold