Rename Py<T> to PyDetached<T>
#3655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
py-detached
branch
from
1f2131a to
4230b17
Compare
davidhewitt
changed the title
Py<T> to PyDetached<T>.Py<T> to PyDetached<T>
davidhewitt
force-pushed
the
py-detached
branch
from
4230b17 to
58e91e6
Compare
|
I think from staring at the diff, this is enough of an ergonomics hit that we should not do this until we're ready to make the new API public. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make space for my preferred name of
Py<'py, T>for the new API in #3382, this PR proposes renamingPy<T>toPyDetached<T>. (Other ideas arePySend<T>andPyUngil<T>.)Benefit of opening a PR is so we can see how painful it looks to do this rename. (And maybe so that internally we can stop writing
Py2<...>everywhere.)I'm split on whether it makes sense to land this rename in 0.21 and then the new
Py<'py, T>in 0.22, or land both at the same time.