add descriptive error msg for __traverse__ receivers other than &self
#4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
reviewed
Apr 4, 2024
adamreichold
reviewed
Apr 4, 2024
CodSpeed Performance ReportMerging #4045 will not alter performanceComparing Summary
|
adamreichold
approved these changes
Apr 4, 2024
davidhewitt
pushed a commit
that referenced
this pull request
Apr 16, 2024
…elf` (#4045) * add descriptive error msg for `__traverse__` receivers other than `self` * add newsfragment * improve error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a descriptive error message if receivers other than
&selfare tried to extract from__traverse__along with the corresponding UI tests. In particular this tests forPyRef,PyRefMut,Boundand&mut self.Fixes #3180