Rename py long > py int #4260 #4284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-PyLong is primarily a historical accident based on the fact that Python 2's integers were split between int and long types, and so the Python C API is based on PyLongObject etc. - So, renaming it to PyInt
|
@davidhewitt |
LilyFoote
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Hey, thanks for taking a look at this.
I don't think you should need to change any code in pyo3-ffi for this issue. Once you've reverted those changes, I suspect you'll start getting more helpful error messages about which bits of the codebase still do need to change.
Co-authored-by: Lily Foote <[email protected]>
Co-authored-by: Lily Foote <[email protected]>
Co-authored-by: Lily Foote <[email protected]>
Co-authored-by: Lily Foote <[email protected]>
|
Superseded by #4347 |
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to PyO3!
By submitting these contributions you agree for them to be dual-licensed under PyO3's MIT OR Apache-2.0 license.
Please consider adding the following to your pull request:
docs:if this is a docs-only change to skip the checkPyO3's CI pipeline will check your pull request, thus make sure you have checked the
Contributing.mdguidelines. To run most of its testslocally, you can run
nox. Seenox --list-sessionsfor a list of supported actions.