Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile error for #[classmethod]/#[staticmethod] on magic methods #4654

Merged
merged 2 commits into from
Oct 26, 2024
Merged

fix compile error for #[classmethod]/#[staticmethod] on magic methods #4654

merged 2 commits into from
Oct 26, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Oct 25, 2024

Closes #4640

@Icxolu Icxolu added the bugfix label Oct 25, 2024
@Icxolu Icxolu mentioned this pull request Oct 25, 2024
Closed
davidhewitt
davidhewitt approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! I'm sure there was a reason why we added that _slf_ref in the past, but if it's not needed any more, great! 😂

@davidhewitt davidhewitt added this pull request to the merge queue Oct 26, 2024
Merged via the queue into PyO3:main with commit 869c4bf Oct 26, 2024
44 checks passed
@Icxolu Icxolu deleted the fix/4640 branch October 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot implement __len__ classmethod (0.21+)
2 participants
@Icxolu @davidhewitt