Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken specialized implementations with Rust 1.40 #615

Merged
merged 2 commits into from
Oct 7, 2019

Conversation

althonos
Copy link
Member

@althonos althonos commented Oct 7, 2019

Here are some things you should check for submitting your pull request:

  • Run cargo fmt (This is checked by travis ci)
  • Run cargo clippy and check there are no hard errors (There are a bunch of existing warnings; This is also checked by travis)
  • If applicable, add an entry in the changelog.
  • If applicable, add documentation to all new items and extend the guide.
  • If applicable, add tests for all new or fixed functions
  • If you changed any python code, run black .. You can install black with pip install black)

This PR hopefully resolves #614.

Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this so quickly!

@kngwyu Do you want to make a 0.8.1 release after that is merged?

@althonos
Copy link
Member Author

althonos commented Oct 7, 2019

No problem! Would be glad to have this released indeed.

@kngwyu
Copy link
Member

kngwyu commented Oct 7, 2019

Thank you for the fix!

@konstin
Yeah, I think we should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust 1.40.0 nightly breaks specialization
3 participants