Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.10.0 #919

Merged
merged 4 commits into from
May 13, 2020
Merged

Bump version to 0.10.0 #919

merged 4 commits into from
May 13, 2020

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented May 11, 2020

I think it's good timing to release.

@kngwyu kngwyu added the blocked label May 11, 2020
@kngwyu
Copy link
Member Author

kngwyu commented May 11, 2020

#920 should be merged before the release.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I also wonder if a decision for #916 should be made before releasing.

CHANGELOG.md Outdated Show resolved Hide resolved
guide/src/migration.md Outdated Show resolved Hide resolved
assert_eq!(hi.len().unwrap(), 5);
```

### No `#![feature(specialization)]` in user code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

guide/src/migration.md Outdated Show resolved Hide resolved

## from 0.9.* to 0.10

### `ObjectProtocol` is removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth noting that ObjectProtocol was also in the prelude? So for many users this change may have been totally invisible.

@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [0.10.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been wondering about making a quick PR to make the changelog messages for 0.10.0 (hopefully) a little easier to read. Happy for me to do that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been wondering about making a quick PR to make the changelog messages for 0.10.0 (hopefully) a little easier to read.

OK 👍 but it's easier for me if you specify what should be changed here.

Copy link
Member Author

@kngwyu kngwyu May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you can push the change directly to this branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will push later

@kngwyu kngwyu removed the blocked label May 12, 2020
@davidhewitt
Copy link
Member

I've pushed a bunch of rewording to the CHANGELOG for 0.10.0. Added some missing stuff and tried to make everything more consistent / simpler to read.

I tried to draw inspiration from Gitlab's guidelines, which I think leads to a pretty good changelog.

Please edit anything you don't like about what I added / wrote.

@kngwyu
Copy link
Member Author

kngwyu commented May 13, 2020

👍

@kngwyu kngwyu merged commit 7e4d1c4 into master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants