Typed PyBuffer #952
Merged
Typed PyBuffer #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks really handy! I was just asking on Gitter if
Was the best route, this seems much more straightforward. |
davidhewitt
approved these changes
Jun 5, 2020
| @@ -146,29 +147,51 @@ fn is_matching_endian(c: u8) -> bool { | |||
| } | |||
|
|
|||
| /// Trait implemented for possible element types of `PyBuffer`. | |||
| pub unsafe trait Element { | |||
| pub unsafe trait Element: Copy { | |||
Co-authored-by: David Hewitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyBufferis now typed asPyBuffer<T>.Since it can only have a single type, it is reasonable to make it typed.
In addition, I implemented
FromPyObjectforPyBuffer<T>.The intention is enabling the use of
PyBufferas an argument ofpyfunction, like:, which means that we can still use fast(=buffer to vec) conversion for function arguments even after #927 is merged.