Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch coverage format for Codecov uploads to the native one. #374

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Switch coverage format for Codecov uploads to the native one. #374

merged 1 commit into from
Apr 19, 2023

Conversation

adamreichold
Copy link
Member

Standing on the shoulders of giants, c.f. PyO3/pyo3#3097

@adamreichold
Copy link
Member Author

So basically the same 15 percent drop in coverage as the change implied for PyO3 for the same reasons.

@davidhewitt
Copy link
Member

I guess we wait with this one to see what the discussion on the PyO3 PR yields? Maybe the drop isn't going to be so bad 🙃

davidhewitt
davidhewitt approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed upstream, I think this makes sense as an improvement now that cargo-llvm-cov is deduplicating regions based on generic instantiations

@adamreichold adamreichold merged commit 4151c25 into main Apr 19, 2023
@adamreichold adamreichold deleted the coverage-json branch April 19, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamreichold @davidhewitt