Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setuptools is not listed as installation requirement #101

Closed
tiran opened this issue Jan 14, 2021 · 0 comments · Fixed by #102
Closed

setuptools is not listed as installation requirement #101

tiran opened this issue Jan 14, 2021 · 0 comments · Fixed by #102

Comments

@tiran
Copy link
Contributor

tiran commented Jan 14, 2021

setuptools_rust has a runtime dependency on setuptools. However setup.cfg does not include setuptools as a requirement. While pip-based installations and virtual environments always have setuptools, other package managers do not necessarily install setuptools.

For example Fedora's RPM macros automatically create dependencies from package metadata. The auto-generate RPM package for setuptools-rust 0.11.6 is missing a runtime dependency on setuptools.
tiran added a commit to tiran/setuptools-rust that referenced this issue Jan 14, 2021
@tiran
Add runtime dependency on setuptools
6830479 
setuptools_rust has a runtime dependency on setuptools. Ensure that all
installations of setuptools_rust have a sufficiently recent version of
setuptools.

Fixes: PyO3#101
Signed-off-by: Christian Heimes <[email protected]>
@tiran tiran mentioned this issue Jan 14, 2021
Merged
tiran added a commit to tiran/setuptools-rust that referenced this issue Jan 14, 2021
@tiran
Add runtime dependency on setuptools
f20d6e6 
setuptools_rust has a runtime dependency on setuptools. Ensure that all
installations of setuptools_rust have a sufficiently recent version of
setuptools.

Fixes: PyO3#101
Signed-off-by: Christian Heimes <[email protected]>
davidhewitt added a commit that referenced this issue Jan 14, 2021
@davidhewitt
Merge pull request #102 from tiran/gh-101-setuptools
6308e0d 
Add runtime dependency on setuptools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add runtime dependency on setuptools tiran/setuptools-rust
1 participant
@tiran