add python 3.12 to CI

.github/workflows/CI.yaml

@@ -19,7 +19,7 @@ jobs:
         - 3.9
         - "3.10"
         - "3.11"
-        # - "3.12"
+        - "3.12"
         os:
         - ubuntu-latest
         - macos-latest

doc/release_notes.rst

@@ -14,6 +14,8 @@ Upcoming Version
 
 * Up to now the `rhs` argument in the `add_constraints` function was not supporting an expression as an input type. This is now added.
 
+* Linopy now supports python 3.12.
+
 Version 0.3.8
 -------------
 

linopy/solvers.py

@@ -11,6 +11,7 @@
 import os
 import re
 import subprocess as sub
+import sys
 from pathlib import Path
 
 import numpy as np
@@ -128,7 +129,7 @@
     if np.isnan(solution.objective):
         return
 
-    if io_api == "mps":
+    if io_api == "mps" and sys.version_info < (3, 12):
         logger.info(
             "Adjusting objective sign due to switched coefficients in MPS file."
         )
@@ -175,6 +176,12 @@
             "Keyword argument `io_api` has to be one of `lp`, `mps' or None"
         )
 
+    # CBC does not like the OBJSENSE line in MPS files, which new highspy versions write
+    if io_api == "mps" and model.sense == "max" and sys.version_info >= (3, 12):
+        raise ValueError(
+            "GLPK does not support maximization in MPS format for Python 3.12+"
+        )
+
     problem_fn = model.to_file(problem_fn)
 
     # printingOptions is about what goes in solution file
@@ -282,6 +289,12 @@
             "Keyword argument `io_api` has to be one of `lp`, `mps` or None"
         )
 
+    # GLPK does not like the OBJSENSE line in MPS files, which new highspy versions write
+    if io_api == "mps" and model.sense == "max" and sys.version_info >= (3, 12):
+        raise ValueError(
+            "GLPK does not support maximization in MPS format for Python 3.12+"
+        )
+
     problem_fn = model.to_file(problem_fn)
     suffix = problem_fn.suffix[1:]
 
@@ -358,7 +371,6 @@
 
     solution = safe_get_solution(status, get_solver_solution)
     maybe_adjust_objective_sign(solution, model.objective.sense, io_api)
-
     return Result(status, solution)
 
 

setup.py

@@ -17,10 +17,11 @@
 
 SOLVERS = [
     "gurobipy",
-    "highspy",
-    "cplex; platform_system != 'Darwin' and python_version <= '3.11'",
+    "highspy>=1.5.0; python_version < '3.12'",
+    "highspy>=1.7.1.dev1; python_version >= '3.12'",
+    "cplex; platform_system != 'Darwin' and python_version < '3.12'",
     "mosek",
-    "mindoptpy",
+    "mindoptpy; python_version < '3.12'",
     "coptpy",
     "xpress; platform_system != 'Darwin' and python_version < '3.11'",
     "pyscipopt; platform_system != 'Darwin'",

test/test_optimization.py

@@ -8,6 +8,7 @@
 
 import logging
 import platform
+import sys
 
 import numpy as np
 import pandas as pd
@@ -384,9 +385,14 @@ def test_model_maximization(model_maximization, solver, io_api):
     m = model_maximization
     assert m.objective.sense == "max"
     assert m.objective.value is None
-    status, condition = m.solve(solver, io_api=io_api)
-    assert status == "ok"
-    assert np.isclose(m.objective.value, 3.3)
+
+    if solver in ["cbc", "glpk"] and io_api == "mps" and sys.version_info >= (3, 12):
+        with pytest.raises(ValueError):
+            m.solve(solver, io_api=io_api)
+    else:
+        status, condition = m.solve(solver, io_api=io_api)
+        assert status == "ok"
+        assert np.isclose(m.objective.value, 3.3)
 
 
 @pytest.mark.parametrize("solver,io_api", params)