-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow removing multiple constraints at once #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 89.26% 89.28% +0.01%
==========================================
Files 15 15
Lines 3354 3359 +5
Branches 771 773 +2
==========================================
+ Hits 2994 2999 +5
Misses 248 248
Partials 112 112 ☔ View full report in Codecov by Sentry. |
aurelije
reviewed
Dec 8, 2023
FabianHofmann
approved these changes
Dec 8, 2023
for more information, see https://pre-commit.ci
Are you fine, if I set the logging from |
sure! |
FabianHofmann
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make possible to pass a list into remove_constraints() to remove multiple constraints at once.
Keeps old functionality, i.e. it is still possible to pass constraint name as a string.
Adds logging, so user can see what constraints are removed.
to remove all constraints:
n.model.remove_constraints(list(n.model.constraints))
to remove a single constraint:
n.model.remove_constraints(['Bus-nodal_balance'])
or
n.model.remove_constraints('Bus-nodal_balance')
closes #210