-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fh/fix 266 #290
Fh/fix 266 #290
Conversation
code coverage upload failed for some reason, could you have a look at this @FabianHofmann ? |
@apfelix thanks for your PR! I retriggered the CI, don't know where that came from. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 89.69% 86.70% -3.00%
==========================================
Files 16 16
Lines 4019 4024 +5
Branches 939 941 +2
==========================================
- Hits 3605 3489 -116
- Misses 281 411 +130
+ Partials 133 124 -9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! thanks @apfelix
fix #266
cached properties of the model's
MatrixAccessor
are cleared (if existent) at the start ofsolve
, to avoid using old cached data on resolving the model after modification.I also added a pytest for this, which failed before and works now.