Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix potential setuptools_scm issues in gh actions #298

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

lkstrp
Copy link
Member

@lkstrp lkstrp commented May 28, 2024

In reference to PyPSA/PyPSA#907 #279 and #292 I just add a fetch for the tags here so that setuptools_scm can detect the version correctly. Right now that doesn't lead to errors, so only to avoid the potential bug search in the future (which I just had).

Fore more details see here.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (07aa9f6) to head (d43bef3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   89.72%   86.72%   -3.00%     
==========================================
  Files          16       16              
  Lines        4037     4037              
  Branches      942      942              
==========================================
- Hits         3622     3501     -121     
- Misses        282      412     +130     
+ Partials      133      124       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FabianHofmann
Copy link
Collaborator

flake 8 does not like some syntax here https://github.com/PyPSA/linopy/actions/runs/9273219169/job/25512792210?pr=298 (?)

@FabianHofmann
Copy link
Collaborator

don't know what is going on with codecov, I am closing and opening the pr in the hope that codecov with work then

@FabianHofmann FabianHofmann merged commit d1aa386 into PyPSA:master Jun 14, 2024
10 of 15 checks passed
@lkstrp lkstrp deleted the fix-ci branch June 28, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants