Composition design review

[FabianHofmann]

Most changes are targeting back-wards compatibility.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (composition-design@cc58dd1). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@                  Coverage Diff                  @@
##             composition-design      #63   +/-   ##
=====================================================
  Coverage                      ?   86.04%           
=====================================================
  Files                         ?       11           
  Lines                         ?     2107           
  Branches                      ?      330           
=====================================================
  Hits                          ?     1813           
  Misses                        ?      222           
  Partials                      ?       72           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[FabianHofmann]

@coroa I don't know if you even have time to review this. Otherwise I'd just merge this. The only thing that I was wondering about: was there any reason for not defining LinearExpression as a dataclass?

[coroa]

@coroa I don't know if you even have time to review this. Otherwise I'd just merge this. The only thing that I was wondering about: was there any reason for not defining LinearExpression as a dataclass?

Agreed, I had quite some time issues the last week. Not much better this week though :).

I didn't dataclass some of the things because, i had intended to write actual __init__ functions as well as __repr__, so that there is not much benefit to dataclasses left. But it was all just on a whim.