Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor workflow_management.py and remove unused imports and code #65

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

srijanpatel
Copy link
Collaborator

@srijanpatel srijanpatel commented Dec 27, 2024

This pull request includes significant changes to the backend/app/nodes/llm directory, primarily involving the removal of several node classes and their associated configurations. Additionally, there are minor updates to the backend/app/api/workflow_management.py file.

Node Removals:

Minor Updates:


Important

Refactor by removing unused node classes and configurations, and update workflow_management.py for cleaner imports and improved code style.

  • Node Removals:
    • Removed MCTSNode, MixtureOfAgentsNode, SampleLLMNode, SelfConsistencyNode, StringOutputLLMNode, StructuredOutputNode, TopKNode, and TreeOfThoughtsNode classes and their configurations.
  • workflow_management.py Updates:
    • Removed unused import DynamicSchemaNodeConfig.
    • Added trailing comma in HTTPException detail string in delete_workflow().
    • Added type annotation Dict[str, str] for output_schema in get_workflow_output_variables().

This description was created by Ellipsis for a7c4132. It will automatically update as commits are pushed.

@srijanpatel srijanpatel linked an issue Dec 27, 2024 that may be closed by this pull request
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a7c4132 in 11 seconds

More details
  • Looked at 1396 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. backend/app/api/workflow_management.py:258
  • Draft comment:
    The type annotation for output_schema is redundant since it is immediately reassigned. Consider removing it for cleaner code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The type annotation for output_schema is redundant since it is immediately reassigned. This redundancy is unnecessary and can be removed for cleaner code.

Workflow ID: wflow_24RzlBnQ6t0B4fKm


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srijanpatel srijanpatel merged commit 1587ae4 into main Dec 27, 2024
@srijanpatel srijanpatel deleted the bugfix/remove-old-style-nodes branch January 7, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unresolved and unused import DynamicSchemaNodeConfig
1 participant