-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/postgres #77
Chore/postgres #77
Conversation
…ocker-compose.yml
…oving redundant checks and directly upgrading the database schema before starting the server.
@ellipsis-dev review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 0edbfd9 in 20 seconds
More details
- Looked at
672
lines of code in20
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. backend/app/schemas/run_schemas.py:18
- Draft comment:
The change fromworkflow_version_id: int
toworkflow_version_id: str
aligns with the change in the database model whereworkflow_version_id
is now a string. This ensures consistency between the database model and the API schema. - Reason this comment was not posted:
Confidence changes required:0%
The change fromworkflow_version_id: int
toworkflow_version_id: str
in theRunResponseSchema
aligns with the change in the database model whereworkflow_version_id
is now a string. This ensures consistency between the database model and the API schema.
2. frontend/src/types/api_types/runSchemas.ts:14
- Draft comment:
The change fromworkflow_version_id: number
toworkflow_version_id: string
aligns with the change in the database model whereworkflow_version_id
is now a string. This ensures consistency between the database model and the API schema. - Reason this comment was not posted:
Confidence changes required:0%
The change fromworkflow_version_id: int
toworkflow_version_id: str
in theRunResponse
interface aligns with the change in the database model whereworkflow_version_id
is now a string. This ensures consistency between the database model and the API schema.
3. backend/app/api/workflow_run.py:37
- Draft comment:
The change fromworkflow_version_id: int
toworkflow_version_id: str
aligns with the change in the database model whereworkflow_version_id
is now a string. This ensures consistency between the database model and the API schema. - Reason this comment was not posted:
Confidence changes required:0%
The change fromworkflow_version_id: int
toworkflow_version_id: str
in thecreate_run_model
function aligns with the change in the database model whereworkflow_version_id
is now a string. This ensures consistency between the database model and the API schema.
4. backend/app/models/run_model.py:36
- Draft comment:
The change fromworkflow_version_id: int
toworkflow_version_id: str
aligns with the change in the database model whereworkflow_version_id
is now a string. This ensures consistency between the database model and the API schema. - Reason this comment was not posted:
Confidence changes required:0%
The change fromworkflow_version_id: int
toworkflow_version_id: str
in theRunModel
class aligns with the change in the database model whereworkflow_version_id
is now a string. This ensures consistency between the database model and the API schema.
Workflow ID: wflow_gAJcwaie6MB47lax
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 087f536 in 11 seconds
More details
- Looked at
23
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. README.md:72
- Draft comment:
Ensure that the.env
file is correctly configured with the necessary PostgreSQL environment variables before starting the services. - Reason this comment was not posted:
Confidence changes required:50%
The README.md file has been updated to reflect the switch from SQLite to PostgreSQL. The changes are consistent with the PR description and the intent to use PostgreSQL as the default database. The instructions for setting up the database have been updated accordingly.
Workflow ID: wflow_SG7X6MycHazTw2nb
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Switch from SQLite to PostgreSQL, update models and configurations, and enhance Docker setup for PostgreSQL support.
.env.example
,alembic.ini
, anddatabase.py
.DATABASE_URL
construction indatabase.py
to use PostgreSQL environment variables.workflow_version_id
fromint
tostr
inworkflow_run.py
,run_schemas.py
, andrunSchemas.ts
.unique=True
toid
fields in models likedataset_model.py
,eval_run_model.py
, and others.autoincrement="auto"
to_intid
fields in models likeeval_run_model.py
,output_file_model.py
, and others.docker-compose.yml
anddocker-compose.prod.yml
.entrypoint.sh
to runalembic upgrade head
on startup.psycopg2-binary
torequirements.txt
for PostgreSQL support.alembic/.gitignore
file.generate_migrations.sh
script for automating Alembic migrations.This description was created by for 087f536. It will automatically update as commits are pushed.