Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle unknown args passed to Trainer.from_argparse_args #1932

Merged
merged 14 commits into from
May 25, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented May 23, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1929

Trainer **kwargs was recently removed #1820

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label May 23, 2020
@mergify mergify bot requested a review from a team May 23, 2020 10:34
@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #1932 into master will increase coverage by 0%.
The diff coverage is 80%.

@@          Coverage Diff           @@
##           master   #1932   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          74      74           
  Lines        4621    4623    +2     
======================================
+ Hits         4050    4052    +2     
  Misses        571     571           

@awaelchli awaelchli marked this pull request as ready for review May 23, 2020 13:07
@awaelchli awaelchli requested review from williamFalcon and Borda May 23, 2020 13:07
@awaelchli awaelchli marked this pull request as draft May 23, 2020 15:55
@awaelchli awaelchli marked this pull request as ready for review May 24, 2020 13:23
@awaelchli awaelchli force-pushed the bugfix/from_arparse_args branch from 98d8b81 to 75d1e2b Compare May 24, 2020 23:39
@mergify
Copy link
Contributor

mergify bot commented May 25, 2020

This pull request is now in conflict... :(

@williamFalcon williamFalcon merged commit 34237cf into master May 25, 2020
@williamFalcon
Copy link
Contributor

yup ran into this myself lol...

@awaelchli
Copy link
Contributor Author

thanks for the merge, great!

@awaelchli awaelchli deleted the bugfix/from_arparse_args branch May 25, 2020 20:26
@Borda Borda added this to the 0.7.7 milestone May 25, 2020
@mergify mergify bot requested a review from a team May 25, 2020 21:01
@Borda Borda modified the milestones: 0.7.7, 0.8.0 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trainer.from_argparse_args fails on unknown kwargs
3 participants