Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

검색 화면 텍스트 필드 UI 수정 및 Services 프로퍼티 추가 #112

Merged
merged 13 commits into from
Mar 21, 2024
Merged

검색 화면 텍스트 필드 UI 수정 및 Services 프로퍼티 추가 #112

merged 13 commits into from
Mar 21, 2024

Conversation

eung7
Copy link
Contributor

@eung7 eung7 commented Mar 20, 2024

Screenshots 📸

커스텀 네비게이션 바에 있는 텍스트 필드
스크린샷 2024-03-20 20 42 15



고민, 과정, 근거 💬

  • 기존 네비게이션 바의 정해진 높이 때문에 UI가 깨진 것을 커스텀 네비게이션 바를 통해 수정했습니다.
  • Services에 ProductInfo, Search를 추가했습니다.



References 📋

@eung7 eung7 added 🔨 Implementation New feature or request 🔍 Search Search View labels Mar 20, 2024
@eung7 eung7 added this to the v2.0.0 milestone Mar 20, 2024
@eung7 eung7 requested a review from a team March 20, 2024 13:28
@eung7 eung7 self-assigned this Mar 20, 2024
@eung7 eung7 linked an issue Mar 20, 2024 that may be closed by this pull request
검색 텍스트 필드 UI 수정 #110
Closed
@eung7
Copy link
Contributor Author

eung7 commented Mar 20, 2024

수정했습니다!
추가적으로 기존 ProductInfo 화면으로 갈 때 Service에 직접 주입하지 않고
ViewModel로만 Id를 주입해도 되는 방식으로 변경했습니다.

@eung7 eung7 requested a review from WhiteHyun March 20, 2024 13:59
WhiteHyun
WhiteHyun previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@WhiteHyun WhiteHyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 고생하셨습니다~~!

@eung7 eung7 requested a review from WhiteHyun March 20, 2024 14:14
@eung7
Copy link
Contributor Author

eung7 commented Mar 21, 2024 •
edited
Loading

GitAction이 말썽이라 겨우 해결했네요...!
다시 Approve 부탁드립니다!
@WhiteHyun

WhiteHyun
WhiteHyun approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@WhiteHyun WhiteHyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣🤣🤣 포맷팅 고생하셨숩니다!

@WhiteHyun WhiteHyun merged commit da07712 into main Mar 21, 2024
2 checks passed
@eung7 eung7 deleted the Feat/Search/110 branch March 21, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhiteHyun WhiteHyun WhiteHyun approved these changes

Assignees

@eung7 eung7

Labels
🔨 Implementation New feature or request 🔍 Search Search View
Projects
PyeonHaeng iOS Iterative development
Status: Done
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

검색 텍스트 필드 UI 수정
2 participants
@eung7 @WhiteHyun