Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

설정 화면 중 만든사람들 보여주는 화면 구현 #123

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

WhiteHyun
Copy link
Member

@WhiteHyun WhiteHyun commented Mar 22, 2024

Screenshots 📸

시연 영상
Simulator Screen Recording - iPhone 15 Pro - 2024-03-22 at 16 31 34

고민, 과정, 근거 💬

  • 번역진 소개를 위해 서버로부터 credits을 요청합니다.
  • 만약 서버 응답 실패시 어떻게 할 지는 아직 따로 처리하지 않았습니다.
  • NoticeDetailView와 동일한 뷰를 사용하므로 MarkdownView라는 이름으로 변경 후에 뷰를 재사용했습니다.

@WhiteHyun WhiteHyun self-assigned this Mar 22, 2024
@WhiteHyun WhiteHyun added this to the v2.0.0 milestone Mar 22, 2024
@WhiteHyun WhiteHyun added 🔧 Enhancement Improvement or Feedback Implementation ⚙️ Settings Settings View 🔨 Implementation New feature or request labels Mar 22, 2024
- Added CreditsView to the SettingsRow NavigationLink to enable navigation to
the CreditsView from the Settings screen.
@WhiteHyun WhiteHyun requested a review from a team March 22, 2024 07:33
@WhiteHyun WhiteHyun changed the title 🚀 Add CreditsURLProtocol, CreditsEndPoint, CreditsService, and CreditsResponse. 설정 화면 중 만든사람들 보여주는 화면 구현 Mar 22, 2024
@WhiteHyun WhiteHyun force-pushed the feature/settings/119 branch from abdcb22 to a651968 Compare March 22, 2024 08:24
Copy link
Contributor

@eung7 eung7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !
저는 아이들이 아니라 제 이름으로 걸어두고 싶어요! ㅋㅋㅋ

@WhiteHyun WhiteHyun merged commit b92589c into main Mar 22, 2024
4 checks passed
@WhiteHyun WhiteHyun deleted the feature/settings/119 branch March 22, 2024 10:40
WhiteHyun added a commit that referenced this pull request Mar 24, 2024
* 🚀 Add CreditsURLProtocol, CreditsEndPoint, CreditsService, and CreditsResponse.

* ✨ Add Credits API and Support with networking setup, and Credits model for displaying creators.

* ✨ Add CreditsView to SettingsRow NavigationLink

- Added CreditsView to the SettingsRow NavigationLink to enable navigation to
the CreditsView from the Settings screen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 Enhancement Improvement or Feedback Implementation 🔨 Implementation New feature or request ⚙️ Settings Settings View
Projects
Development

Successfully merging this pull request may close these issues.

만든사람들을 누르면 서버에서 데이터를 받아와 개발진과 번역진을 소개한다.
2 participants