Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

홈 화면 미비된 UI 구현 / 네트워킹 timeout 5초로 수정 #136

Merged
merged 7 commits into from
Mar 27, 2024
Merged

홈 화면 미비된 UI 구현 / 네트워킹 timeout 5초로 수정 #136

merged 7 commits into from
Mar 27, 2024

Conversation

WhiteHyun
Copy link
Member

Screenshots 📸

네트워크 오류 후 다시 데이터 가져오도록 수정 바텀시트 체크표시
RPReplay_Final1711432954 RPReplay_Final1711432954



고민, 과정, 근거 💬

  • 바텀시트 선택 시 오른쪽 체크 표시 추가
  • 데이터 가져오는 것 실패 시 토스트 띄우기
  • 지금 로직으로는 한 번 로딩 실패시 다시 가져오지 못하는 현상 존재했는데 다시 네트워크 연결하고난 뒤 다시 한 번 왔다갔다하면 데이터를 가지고오도록 수정했습니다.

@WhiteHyun WhiteHyun added 🔧 Enhancement Improvement or Feedback Implementation 🏠 Home Home View labels Mar 26, 2024
@WhiteHyun WhiteHyun added this to the v2.0.0 milestone Mar 26, 2024
@WhiteHyun WhiteHyun requested a review from a team March 26, 2024 06:05
@WhiteHyun WhiteHyun self-assigned this Mar 26, 2024
@WhiteHyun WhiteHyun linked an issue Mar 26, 2024 that may be closed by this pull request
[Feat]: 홈 화면 미비된 개발 구현 #135
Closed
4 tasks
@WhiteHyun WhiteHyun merged commit 2fec58b into main Mar 27, 2024
2 checks passed
@WhiteHyun WhiteHyun deleted the feature/home/135 branch March 27, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WhiteHyun WhiteHyun

Labels
🔧 Enhancement Improvement or Feedback Implementation 🏠 Home Home View
Projects
PyeonHaeng iOS Iterative development
Status: Done
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

[Feat]: 홈 화면 미비된 개발 구현
1 participant
@WhiteHyun