-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home UI 구현 #16
Merged
Merged
Home UI 구현 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
eung7
suggested changes
Jan 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다! SwiftUI는 파일이 너무 많이 생겨버려서 고민이었는데,
이렇게 관련된 파일 안에 View
구조체를 많이 만드는 것도 하나의 방법이겠네요!
저도 @WhiteHyun 님 처럼 WWDC나 공식문서를 먼저 참고하는 습관을 들여야겠습니다..! 👍👍
수고하셨습니다. 😎
PyeonHaeng-iOS/Sources/Scenes/HomeScene/HomeProductListView.swift
Outdated
Show resolved
Hide resolved
PyeonHaeng-iOS/Sources/Scenes/HomeScene/HomeProductDetailSelectionView.swift
Outdated
Show resolved
Hide resolved
….swift Co-authored-by: eung7 <[email protected]>
…lectionView.swift Co-authored-by: eung7 <[email protected]>
eung7
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots 📸
Note
서버로부터 내려받는 제품목록은 아직 한글이어서 백엔드로부터 데이터를 받을 때 이를 수정해야합니다.
고민, 과정, 근거 💬
SF Symbol
로 전부 적용해두었습니다. 디자인 측에서 아이콘 정리가 되는대로 업데이트할 예정입니다.PromotionTagView
와toStringWithComma()
로 변경할 예정입니다.트러블 슈팅
Localization 기능을 지원하는 것 까지는 좋았으나 부분 문자열의 색상을 변경하는 것은 꽤나 고역이었습니다.
Text 메서드에서 부분 문자만 색상처리하는 modifier는 존재하지 않는 것 같더라고요.
그래서 WWDC 영상 자료좀 찾아보다가
AttributeString(localized:)
를 알게 되었습니다.[2]Localizable에서 작업한 문자열을 적용한 뒤 AttributedSubString에 존재하는 foregroundColor값을 수정하여 해결했습니다.
WWDC 최고.. 🙌
References 📋